Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add via parameter on join room requests as per MSC4156 #3438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add via parameter on join room requests as per MSC4156 #3438

wants to merge 1 commit into from

Conversation

Johennes
Copy link

@Johennes Johennes commented Oct 7, 2024 •
edited
Loading

This implements MSC4156 which will ship with Matrix 1.12.

Pull Request Checklist

  • I have added Go unit tests or Complement integration tests for this PR or I have justified why this PR doesn't need tests
    The existing joinroom_test.go doesn't seem to assert on the server_name parameter. I'd be happy to add tests for both server_name and via but might need some guidance.
  • Pull request includes a sign off below using a legally identifiable name or I have already signed off privately

Signed-off-by: Johannes Marbach <[email protected]>

@Johennes Johennes marked this pull request as ready for review October 7, 2024 09:03
@Johennes Johennes requested a review from a team as a code owner October 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Johennes