Use EDU activity to determine user idleness #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update matrix-appservice-bridge to 2.2.0-rc2
Half-Shot
force-pushed
the
hs/edu-activity
branch
from
f03b872
to
a9483fe
Compare
benparsons
reviewed
Oct 15, 2020
src/bridge/IrcBridge.ts
Outdated
| userIds = [event.sender]; | ||
| } | ||
| else if (event.type === "m.receipt") { | ||
| userIds = Object.keys(Object.values(event.content).map((v) => v["m.read"])); |
There was a problem hiding this comment.
Is this taking ALL the m.reads? Surely we still only want the sender in this point? Or you refresh the whole list whenever there's a new m.receipt?
There was a problem hiding this comment.
Synapse sends new receipts in the format https://matrix.org/docs/spec/client_server/r0.6.0#m-receipt, which makes it a bit tricky to determine what's changed. We could do some quick filtering to exclude stale receipts though.
There was a problem hiding this comment.
I've tried something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas previously we've relied on users sending messages to prove if they are a lurker, this change would check to see if the users have sent any federated activity like presence, read receipts or typing. This allows the idle kicker to be much more fair about who it kicks.