Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Add type support for Matrix CS API guest scope #1454

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Add type support for Matrix CS API guest scope #1454

merged 2 commits into from
Aug 8, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Aug 5, 2023

According to MSC2967

sandhose
sandhose suggested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for this one, especially since the parsing/serialising of all this is not that obvious

Otherwise LGTM

@sandhose sandhose merged commit 281eea5 into matrix-org:main Aug 8, 2023
21 checks passed
@zecakeh zecakeh deleted the scope-matrix-guest branch August 9, 2023 09:18
@matrixbot matrixbot mentioned this pull request Sep 9, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandhose sandhose sandhose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zecakeh @sandhose