Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

RoomVC: Retain cycles prevent RoomViewController to be deallocated #942

Merged
merged 5 commits into from
Oct 28, 2021
Merged

RoomVC: Retain cycles prevent RoomViewController to be deallocated #942

merged 5 commits into from
Oct 28, 2021

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare commented Oct 28, 2021 •
edited
Loading

pixlwave
pixlwave approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pixlwave
Copy link
Member

Oh, this one is missing a changelog entry though :)

@SBiOSoftWhare SBiOSoftWhare merged commit 359e376 into develop Oct 28, 2021
@SBiOSoftWhare SBiOSoftWhare deleted the steve/5055_roomvc_retain_cycles branch October 28, 2021 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBiOSoftWhare @pixlwave