MX3PidAddManager: Use a non empty client_secret to discover /account/3pid/add flows #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3pid/add flows element-hq/element-ios/issues/3966 We need it because Synapse now checks that it is not empty. The proper fix will be to use the same client_secret (and sid) from the beginning of the authentication. But this will be done later with element-hq/element-ios#3970.
gileluard
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix element-hq/element-ios/issues/3966
We need it because Synapse now checks that it is not empty. We can use any non empty strings.
The proper fix will be to use the same client_secret (and sid) from the beginning of the authentication. But this will be done later with element-hq/element-ios#3970.