MXTools: Avoid releasing null pointer to fix crash on M1 simulator #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a Simulator bug on the Apple M1, `UTTypeCreatePreferredIdentifierForTag` can unexpectedly return `NULL`. This causes a crash because the return value is later passed into `CFRelease` which explicitly disallows `NULL` arguments. This commit fixes the issue by ensuring the return value is not `NULL` before proceeding. Fixes: element-hq/element-ios#4140 Signed-off-by: Johannes Marbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Simulator bug on the Apple M1,
UTTypeCreatePreferredIdentifierForTagcan unexpectedly returnNULL. This causes a crash because the return value is later passed intoCFReleasewhich explicitly disallowsNULLarguments.This commit fixes the issue by ensuring the return value is not
NULLbefore proceeding.Fixes: element-hq/element-ios#4140
Signed-off-by: Johannes Marbach [email protected]
Pull Request Checklist