Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXRoomEventFilter: New property names for relation types and senders #1395

Merged
merged 5 commits into from
Mar 9, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Mar 8, 2022

Fix element-hq/element-ios#5705

This is just updating some property names right now, to be more aligned with stable values, which i'll update later in another PR.

@ismailgulek ismailgulek marked this pull request as ready for review March 9, 2022 12:01
@ismailgulek ismailgulek requested review from a team and pixlwave and removed request for a team March 9, 2022 12:01
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 small comment.

MatrixSDK/Data/Filters/MXRoomEventFilter.h Outdated Show resolved Hide resolved
@ismailgulek ismailgulek merged commit 3f8940b into develop Mar 9, 2022
@ismailgulek ismailgulek deleted the ismail/5705_new_property_names branch March 9, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads: Update property stable values
2 participants