Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument metrics for iOS for the IA project #5401 #1409

Merged
merged 5 commits into from
Mar 17, 2022

Conversation

gileluard
Copy link
Contributor

- MXSpaceService: added `spaceSummaries` property
@gileluard gileluard requested review from a team and pixlwave and removed request for a team March 16, 2022 15:59
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo docs! ✨

LGTM, couple of minor comments.

MatrixSDK/Space/MXSpaceService.swift Outdated Show resolved Hide resolved
MatrixSDK/Space/MXSpaceService.swift Outdated Show resolved Hide resolved
MatrixSDK/Space/MXSpaceService.swift Outdated Show resolved Hide resolved
MatrixSDK/Space/MXSpaceService.swift Outdated Show resolved Hide resolved
@gileluard gileluard merged commit 3abf46f into develop Mar 17, 2022
@gileluard gileluard deleted the gil/5401_Instrument_metrics_for_the_IA_project branch March 17, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants