Return room identifier and known servers when resolving alias #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
aringenbach
and removed request for
a team
aringenbach
approved these changes
Mar 29, 2022
| XCTAssertEqualObjects(roomId2, roomId, @"Mapping from room alias to room ID is wrong"); | ||
| XCTAssertNotNil(resolution); | ||
| XCTAssertNotEqual(resolution.roomId.length, 0); | ||
| XCTAssertEqualObjects(resolution.roomId, roomId, @"Mapping from room alias to room ID is wrong"); | ||
|
|
There was a problem hiding this comment.
I wonder if we could test something relevant on the servers list 🤔
There was a problem hiding this comment.
Oh yea! I was going to do that and then it slipped my mind, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to element-hq/element-ios#4858
The directory/room/<room_alias> endpoint used to convert room alias to a room identifier returns a list of servers that are aware of the room. In the existing SDK implementation this list of servers is never stored (we only grab the identifier), meaning that if we later want to join this room from another home server, it is no longer possible without the knowledge of the servers.
To solve this on the SDK side, store both
room_idas well as list ofserversin a newMXRoomAliasResolutionobject which can be fetched viaresolveRoomAliasendpoint, replacing the simplerroomIdForAlias