Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location sharing: MXBeaconInfoSummary add isActive property #1454

Merged
merged 5 commits into from
May 4, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare requested review from a team and MaximeEvrard42 and removed request for a team May 3, 2022 13:41
/// - roomId: The room id of the room
/// - Returns: Room beacon info summaries
public func getBeaconInfoSummaries(inRoomWithId roomId: String) -> [MXBeaconInfoSummaryProtocol] {
return self.session.aggregations.beaconAggegations.getBeaconInfoSummaries(inRoomWithId: roomId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use this PR to fix the name of this class beaconAggRegations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@SBiOSoftWhare SBiOSoftWhare merged commit b6fad76 into develop May 4, 2022
@SBiOSoftWhare SBiOSoftWhare deleted the steve/6113_beacon_info_summary_active branch May 4, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants