Rooms: support for attributedPartialTextMessage storage #1457
Conversation
MatrixSDK/Data/MXRoom.h
Outdated
| /** | ||
| The text message partially typed by the user but not yet sent. | ||
| The value is stored by the session store. Thus, it can be retrieved | ||
| when the application restarts. | ||
| */ | ||
| // @TODO(summary): Move to MXRoomSummary | ||
| @property (nonatomic) NSString *partialTextMessage; | ||
| @property (nonatomic) NSAttributedString *attributedPartialTextMessage; |
There was a problem hiding this comment.
Should this maybe be partialAttributedTextMessage instead? 🤔 It's probably going to mean a lot of changes if you modify it now, up to you.
There was a problem hiding this comment.
Good point, this will go obviously super smoothly with Xcode's awesome refactors 👍
MatrixSDK/Data/MXRoomMember.h
Outdated
| @@ -22,7 +22,7 @@ | |||
| /** | |||
| `MXRoomMember` is the information about a user in a room. | |||
| */ | |||
| @interface MXRoomMember : NSObject | |||
| @interface MXRoomMember : NSObject<NSCoding> | |||
There was a problem hiding this comment.
Is it really necessary to encode the whole RoomMember for pills to work? Is there a possibility we expose private data here?
There was a problem hiding this comment.
We discussed this with @SBiOSoftWhare already, I suppose it could be worth it to use some intermediate PillData struct with only what we really need (which would be only 3 strings so it will be easily codable/decodable for free)
I will make that change then
This reverts commit d2501d0.
Rooms can now store an attributed string as partialTextMessage. Similar NSString API is now deprecated.
Support for: element-hq/element-ios#3526