MXRoom: Support reply to beacon info event (PSG-4) #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBiOSoftWhare
requested review from
a team and
aringenbach
and removed request for
a team
aringenbach
approved these changes
Jul 13, 2022
MatrixSDK/Data/MXRoom.m
Outdated
Comment on lines
2174
to
2175
| senderMessageBody = question; | ||
| senderMessageFormattedBody = senderMessageBody; |
There was a problem hiding this comment.
If this happen on several other cases, I suppose we could add a specific setter that updates both
There was a problem hiding this comment.
Good catch I simplified the code
Codecov Report
@@ Coverage Diff @@
## develop #1525 +/- ##
========================================
Coverage 12.04% 12.05%
========================================
Files 512 512
Lines 83823 83824 +1
Branches 35782 35784 +2
========================================
+ Hits 10099 10105 +6
+ Misses 73356 73351 -5
Partials 368 368
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-ios#6423