Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build flag for symmetric backup #1567

Merged
merged 3 commits into from
Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions MatrixSDK/Crypto/KeyBackup/MXKeyBackup.m
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,19 @@ @implementation MXKeyBackup

+ (void)initialize
{
AlgorithmClassesByName = @{
kMXCryptoCurve25519KeyBackupAlgorithm: MXCurve25519KeyBackupAlgorithm.class,
kMXCryptoAes256KeyBackupAlgorithm: MXAes256KeyBackupAlgorithm.class
};
if (MXSDKOptions.sharedInstance.enableSymmetricBackup)
{
AlgorithmClassesByName = @{
kMXCryptoCurve25519KeyBackupAlgorithm: MXCurve25519KeyBackupAlgorithm.class,
kMXCryptoAes256KeyBackupAlgorithm: MXAes256KeyBackupAlgorithm.class
};
}
else
{
AlgorithmClassesByName = @{
kMXCryptoCurve25519KeyBackupAlgorithm: MXCurve25519KeyBackupAlgorithm.class,
};
}
DefaultAlgorithmClass = MXCurve25519KeyBackupAlgorithm.class;
}

Expand Down
2 changes: 1 addition & 1 deletion MatrixSDK/Crypto/MXCrypto.m
Original file line number Diff line number Diff line change
Expand Up @@ -664,9 +664,9 @@ - (MXEventDecryptionResult *)decryptEvent2:(MXEvent *)event inTimeline:(NSString
NSDictionary *details = @{
@"event_id": event.eventId ?: @"unknown",
@"error": result.error ?: @"unknown",
@"event": event.JSONDictionary ?: @"unknown"
};
MXLogErrorDetails(@"[MXCrypto] decryptEvent", details);
MXLogDebug(@"[MXCrypto] decryptEvent: Unable to decrypt event %@", event.JSONDictionary);

if ([result.error.domain isEqualToString:MXDecryptingErrorDomain]
&& result.error.code == MXDecryptingErrorBadEncryptedMessageCode)
Expand Down
7 changes: 7 additions & 0 deletions MatrixSDK/MXSDKOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,13 @@ NS_ASSUME_NONNULL_BEGIN

#endif

/**
Enable symmetric room key backups

@remark NO by default
*/
@property (nonatomic) BOOL enableSymmetricBackup;

@end

NS_ASSUME_NONNULL_END
2 changes: 2 additions & 0 deletions MatrixSDK/MXSDKOptions.m
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ - (instancetype)init
#if DEBUG
_enableCryptoV2 = NO;
#endif

_enableSymmetricBackup = NO;
}

return self;
Expand Down
10 changes: 10 additions & 0 deletions MatrixSDKTests/MXAes256KeyBackupTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ @interface MXAes256KeyBackupTests : MXBaseKeyBackupTests

@implementation MXAes256KeyBackupTests

- (void)setUp
{
MXSDKOptions.sharedInstance.enableSymmetricBackup = YES;
}

- (void)tearDown
{
MXSDKOptions.sharedInstance.enableSymmetricBackup = NO;
}

- (NSString *)algorithm
{
return kMXCryptoAes256KeyBackupAlgorithm;
Expand Down
1 change: 1 addition & 0 deletions changelog.d/pr-1567.change
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
KeyBackups: Add build flag for symmetric backup