Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor verification manager, requests, transactions #1599

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 5, 2022

Turn MXKeyVerificationManager into a protocol and rename all existing objective-c implementations to MXLegacy... variants. This is to make Crypto V2 verification api safer.

@Anderas Anderas requested review from a team and gileluard and removed request for a team October 5, 2022 17:35
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 13.48% // Head: 13.48% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ee35c54) compared to base (214c631).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1599      +/-   ##
===========================================
- Coverage    13.48%   13.48%   -0.01%     
===========================================
  Files          541      541              
  Lines        86699    86711      +12     
  Branches     36833    36840       +7     
===========================================
  Hits         11693    11693              
- Misses       74564    74576      +12     
  Partials       442      442              
Impacted Files Coverage Δ
MatrixSDK/Crypto/MXCrypto.m 1.99% <0.00%> (ø)
...SDK/Crypto/Verification/MXKeyVerificationManager.m 0.00% <0.00%> (ø)
...rification/Requests/MXKeyVerificationByDMRequest.m 0.00% <ø> (ø)
...tion/Requests/MXKeyVerificationByToDeviceRequest.m 0.00% <ø> (ø)
...o/Verification/Requests/MXKeyVerificationRequest.m 0.00% <0.00%> (ø)
...ification/Status/MXKeyVerificationStatusResolver.m 0.00% <ø> (ø)
...cation/Transactions/MXKeyVerificationTransaction.m 0.00% <0.00%> (ø)
...fication/Transactions/QRCode/MXQRCodeTransaction.m 0.00% <ø> (ø)
...cation/Transactions/SAS/MXIncomingSASTransaction.m 0.00% <ø> (ø)
...cation/Transactions/SAS/MXOutgoingSASTransaction.m 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Anderas Anderas merged commit 29222ee into develop Oct 6, 2022
@Anderas Anderas deleted the andy/verification_refactor branch October 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants