Cross-sign self after restoring session with Crypto V2 #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/crosssign_self
branch
2 times, most recently
from
c809954
to
a2d4688
Compare
Anderas
force-pushed
the
andy/crosssign_self
branch
from
a2d4688
to
baabc21
Compare
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
Codecov ReportBase: 15.90% // Head: 15.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## andy/crypto_protocol #1616 +/- ##
=====================================================
Coverage 15.90% 15.91%
=====================================================
Files 577 577
Lines 90959 90984 +25
Branches 38384 38394 +10
=====================================================
+ Hits 14466 14479 +13
- Misses 76025 76037 +12
Partials 468 468
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement several missing methods to fully cross-sign current user and device after restoring session with security key.