Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all Crypto tasks with default priority #1639

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Nov 21, 2022

  • Run all crypto Tasks with default priority rather than assigning medium
  • Make sure CryptoV2 does not get initialized more than once (which can happen during failing initial syncs)
  • Remove unnecessary processing of outgoing requests

@Anderas Anderas requested review from a team and pixlwave and removed request for a team November 21, 2022 11:53
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 36.18% // Head: 16.03% // Decreases project coverage by -20.15% ⚠️

Coverage data is based on head (7f8a2be) compared to base (756c355).
Patch coverage: 5.55% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1639       +/-   ##
============================================
- Coverage    36.18%   16.03%   -20.16%     
============================================
  Files          583      583               
  Lines        92556    92561        +5     
  Branches     40240    39042     -1198     
============================================
- Hits         33495    14840    -18655     
- Misses       58056    77234    +19178     
+ Partials      1005      487      -518     
Impacted Files Coverage Δ
MatrixSDK/Crypto/MXCryptoV2.swift 0.80% <0.00%> (-0.01%) ⬇️
...pto/KeyBackup/Engine/MXCryptoKeyBackupEngine.swift 47.33% <100.00%> (ø)
MatrixSDKTests/MatrixSDKTestsData.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Data/MXOlmSession.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Utils/MXDateProvider.swift 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Utils/MXCryptoTools.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Devices/MXDeviceList.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Data/MXOlmSessionResult.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Migration/MXCryptoVersion.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/JSONModels/Sync/Room/MXRoomSyncState.m 0.00% <0.00%> (-100.00%) ⬇️
... and 179 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit 5131019 into develop Nov 21, 2022
@Anderas Anderas deleted the andy/crypto_fixes branch November 21, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants