Do not track cancellation errors #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/cancellation_tracking
branch
from
e17a743
to
8f1c32d
Compare
Anderas
requested review from
a team and
pixlwave
and removed request for
a team
Anderas
commented
Dec 15, 2022
| @@ -30,12 +30,20 @@ class MXAnalyticsDestination: BaseDestination { | |||
|
|
|||
| override func send(_ level: SwiftyBeaver.Level, msg: String, thread: String, file: String, function: String, line: Int, context: Any? = nil) -> String? { | |||
| let message = super.send(level, msg: msg, thread: thread, file: file, function: function, line: line, context: context) | |||
| #if !DEBUG | |||
There was a problem hiding this comment.
Moving the compiler check to the parent, otherwise cannot write unit tests for this class
Anderas
force-pushed
the
andy/cancellation_tracking
branch
from
8f1c32d
to
5c87132
Compare
pixlwave
approved these changes
Dec 15, 2022
Yea exactly. And actually network connectivity errors may still be useful to track, because they are not caused / expected by the user, so typically result in some kind of visible error, unlike explicit cancellations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We log errors in a lot of places across the codebase via
MXLog.error(... error)passing in any error that was returned from some api, incl rest clients that may return cancellation errors. These are not userful to track in analytics as they occur due to some user action. Instead of filtering them out in the many many places where we log errors, we will filter them out all at once inMXAnalyticsDestination