Upload fallback keys with Crypto V2 #1697
Conversation
Anderas
requested review from
a team and
pixlwave
and removed request for
a team
Codecov ReportBase: 37.52% // Head: 37.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1697 +/- ##
========================================
Coverage 37.52% 37.53%
========================================
Files 609 609
Lines 95117 95137 +20
Branches 41283 41297 +14
========================================
+ Hits 35695 35710 +15
- Misses 58383 58386 +3
- Partials 1039 1041 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -60,6 +60,8 @@ class MXBackgroundCryptoV2: MXBackgroundCrypto { | |||
| - to-device events : \(syncResponse.toDevice?.events.count ?? 0) | |||
| - devices changed : \(syncResponse.deviceLists?.changed?.count ?? 0) | |||
| - devices left : \(syncResponse.deviceLists?.left?.count ?? 0) | |||
| - one time keys : \(syncResponse.deviceOneTimeKeysCount?[kMXKeySignedCurve25519Type] ?? 0) | |||
| - fallback keys : \(syncResponse.unusedFallbackKeys ?? []) | |||
There was a problem hiding this comment.
I'm sure its not, but double checking: Is this going to log keys that are sensitive?
There was a problem hiding this comment.
Those keys are public, after all they get uploaded to the server.
There was a problem hiding this comment.
Yea, actually in this particular log we only print the count of keys (or type in the case of fallback keys), but I have also started logging the actual keys elsewhere so your question is valid (and it is safe as we only print the public keys)
Upload fallback keys via
keys/uploadwhenever present in the body ofUploadKeysRequest.Additionally:
MXKeysQuerySchedulerintoMXCryptoRequests(rather than the other way around), which hides away the details of makingkeys/queryrequestsMXCryptoSDKLogger