Set passphrase for the crypto store #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/crypto_password
branch
from
29521d7
to
ba198f2
Compare
Anderas
requested review from
a team and
alfogrillo
and removed request for
a team
Anderas
force-pushed
the
andy/crypto_password
branch
from
ba198f2
to
8c08d1b
Compare
Codecov ReportBase: 17.45% // Head: 17.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1699 +/- ##
===========================================
- Coverage 17.45% 17.44% -0.01%
===========================================
Files 609 609
Lines 95134 95162 +28
Branches 40089 40094 +5
===========================================
- Hits 16603 16601 -2
- Misses 78025 78055 +30
Partials 506 506
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Anderas
force-pushed
the
andy/crypto_password
branch
from
8c08d1b
to
47db894
Compare
alfogrillo
approved these changes
Jan 30, 2023
Thanks. Yea some flaky tests + one I could not fix due to how OlmKit delegates keys. Will fix this in a separate PR, and disabled that test for now (not in production yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use existing
MXKeyProvidermechanism to get a new key that is used as base64-encoded passphrase when migrating or creatingOlmMachinein crypto V2. This means all data stored in the underlying sqlite db will be encrypted.Additionally: