Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync polls rules (PSG-77, PSG-1097) #1702

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Sync polls rules (PSG-77, PSG-1097) #1702

merged 5 commits into from
Jan 31, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR add completion blocks for updating push rules.
Completion blocks have been added for:

  • Enabling/disabling a push rule
  • Updated actions of a push rule

@alfogrillo alfogrillo mentioned this pull request Jan 30, 2023
Merged
@alfogrillo alfogrillo requested review from a team and stefanceriu and removed request for a team January 30, 2023 16:57
@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Base: 17.43% // Head: 37.53% // Increases project coverage by +20.09% 🎉

Coverage data is based on head (1f5997c) compared to base (46a6764).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 1f5997c differs from pull request most recent head 0fe0d74. Consider uploading reports for the commit 0fe0d74 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #1702       +/-   ##
============================================
+ Coverage    17.43%   37.53%   +20.09%     
============================================
  Files          610      610               
  Lines        95234    95252       +18     
  Branches     40122    41333     +1211     
============================================
+ Hits         16607    35755    +19148     
+ Misses       78122    58456    -19666     
- Partials       505     1041      +536
Impacted Files Coverage Δ
...atrixSDK/NotificationCenter/MXNotificationCenter.m 21.93% <0.00%> (+4.96%) ⬆️
...o/Algorithms/RoomEvent/MXRoomEventDecryption.swift 54.80% <0.00%> (-0.54%) ⬇️
MatrixSDK/Utils/Media/MXMediaManager.m 1.88% <0.00%> (+0.47%) ⬆️
MatrixSDK/Contrib/Swift/MXRestClient.swift 2.22% <0.00%> (+0.74%) ⬆️
...gations/LocationSharing/MXBeaconAggregations.swift 4.44% <0.00%> (+1.26%) ⬆️
MatrixSDKTests/MXBackgroundSyncServiceTests.swift 1.84% <0.00%> (+1.84%) ⬆️
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 23.12% <0.00%> (+1.87%) ⬆️
MatrixSDK/Contrib/Swift/MXSession.swift 14.38% <0.00%> (+2.05%) ⬆️
MatrixSDK/Crypto/Recovery/MXRecoveryService.m 2.33% <0.00%> (+2.33%) ⬆️
...ventsEnumerator/MXEventsByTypesEnumeratorOnArray.m 91.89% <0.00%> (+2.70%) ⬆️
... and 192 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stefanceriu
stefanceriu approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline, looks good otherwise 👍

MatrixSDK/NotificationCenter/MXNotificationCenter.h Outdated Show resolved Hide resolved
MatrixSDK/NotificationCenter/MXNotificationCenter.h Outdated Show resolved Hide resolved
MatrixSDK/NotificationCenter/MXNotificationCenter.m Outdated Show resolved Hide resolved
@alfogrillo alfogrillo merged commit 9e36625 into develop Jan 31, 2023
@alfogrillo alfogrillo deleted the alfogrillo/sync_polls_rules branch January 31, 2023 09:28
Anderas added a commit that referenced this pull request Feb 2, 2023
@Anderas
Revert "Merge pull request #1702 from matrix-org/alfogrillo/sync_poll…
ecee616 
…s_rules"

This reverts commit 9e36625, reversing
changes made to d772603.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @stefanceriu