Fix JSONDictionary of keys query responses #1707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading user keys via
keys/query
we sometimes usedownloadByChunks
method that makes several HTTP requests and combines the result into a singleMXKeysQueryResponse
. The Crypto V2 relies on getting the value of this response viaJSONDictionary
property, however this property was previously just returning whatever initial value was used to create it, and is nil when combining multiple responses together.To solve this we cannot rely on stored property but rather have to compute the
JSONDictionary
out of the current values of the response. Additionally there was a minor bug indownloadByChunks
that would trigger this problem even if we are downloading exactly chunk-sized number of users