Fixed some scenarios where an answered call keeps ringing. #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid updating the state of an ended call - Invalidate the expiration timer once the call has been answered or declined elsewhere
nimau
force-pushed
the
nimau/fix-call_keeps_ringing
branch
from
6a06b90
to
54c717f
Compare
Codecov ReportBase: 17.52% // Head: 37.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1710 +/- ##
============================================
+ Coverage 17.52% 37.41% +19.88%
============================================
Files 612 612
Lines 95947 95958 +11
Branches 40259 41475 +1216
============================================
+ Hits 16813 35899 +19086
+ Misses 78623 59009 -19614
- Partials 511 1050 +539
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some scenarios where a call continues to ring, even after being answered (or declined) elsewhere.
Related issues:
element-hq/element-ios#6614
The main issue here is that the expiration timer may be fired after 1 minute for a call that is already ended (because it has been answered elsewhere). In this case, setting its state to ended can pause the MXSession and prevents the current ringing call to receive any further events.
Here is the list of changes made to fix this issue: