🟢 Apply (polls) push rules client side for encrypted rooms #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 17.52% // Head: 17.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1714 +/- ##
===========================================
- Coverage 17.52% 17.51% -0.01%
===========================================
Files 612 612
Lines 95983 95988 +5
Branches 40286 40289 +3
===========================================
- Hits 16823 16817 -6
- Misses 78649 78660 +11
Partials 511 511
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aringenbach
approved these changes
Feb 9, 2023
| @@ -101,6 +101,9 @@ import Foundation | |||
| public func pushRule(matching event: MXEvent, | |||
| roomState: MXRoomState, | |||
| currentUserDisplayName: String?) -> MXPushRule? { | |||
| // getting the uncrypted event if present or fallback | |||
There was a problem hiding this comment.
Suggested change
| // getting the uncrypted event if present or fallback | |
| // getting the unencrypted event if present or fallback |
alfogrillo
reviewed
Feb 9, 2023
added 3 commits
February 10, 2023 17:18
…apply_poll_push_rules_encrypted-rooms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push rules for an event was broken because it was reading the encrypted one.
Now if present the clear event, the proper rule id is matching properly.
It was also missing the pushRulesManager's handle account data in the updateBackgroundServiceStoresIfNeeded, that way it was not synchronised and a reboot of the app was needed in order to fetch the proper push rules