Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the media download would not start until the end of the scroll #1721

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Feb 16, 2023

This PR fixes an issue with the back pagination where images would not download until the end of the scroll.

@nimau nimau force-pushed the nimau/fix-medialoader-runloopmode branch from fa5a90c to 10affca Compare February 16, 2023 09:59
@nimau nimau marked this pull request as ready for review February 16, 2023 10:00
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 37.35% // Head: 17.62% // Decreases project coverage by -19.74% ⚠️

Coverage data is based on head (10affca) compared to base (0be841e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1721       +/-   ##
============================================
- Coverage    37.35%   17.62%   -19.74%     
============================================
  Files          612      612               
  Lines        96133    96132        -1     
  Branches     41556    40348     -1208     
============================================
- Hits         35912    16939    -18973     
- Misses       59171    78683    +19512     
+ Partials      1050      510      -540     
Impacted Files Coverage Δ
MatrixSDK/Utils/Media/MXMediaLoader.m 0.00% <0.00%> (ø)
MatrixSDKTests/MatrixSDKTestsData.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Utils/MXDateProvider.swift 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Utils/MXCryptoTools.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Devices/MXDeviceList.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Data/MXOlmSessionResult.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/Crypto/Migration/MXCryptoVersion.h 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/JSONModels/Sync/Room/MXRoomSyncState.m 0.00% <0.00%> (-100.00%) ⬇️
MatrixSDK/JSONModels/Sync/MXPresenceSyncResponse.m 0.00% <0.00%> (-100.00%) ⬇️
...atrixSDK/JSONModels/Sync/Room/MXRoomSyncTimeline.m 0.00% <0.00%> (-100.00%) ⬇️
... and 187 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nimau nimau merged commit dce98fc into develop Feb 16, 2023
@nimau nimau deleted the nimau/fix-medialoader-runloopmode branch February 16, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants