Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unread filter logics #1723

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo requested review from a team and flescio and removed request for a team February 22, 2023 11:03
Copy link
Contributor

@flescio flescio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 17.63% // Head: 37.39% // Increases project coverage by +19.76% 🎉

Coverage data is based on head (2b7bee7) compared to base (5821aa5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1723       +/-   ##
============================================
+ Coverage    17.63%   37.39%   +19.76%     
============================================
  Files          612      612               
  Lines        96162    96165        +3     
  Branches     40367    41572     +1205     
============================================
+ Hits         16960    35964    +19004     
+ Misses       78687    59147    -19540     
- Partials       515     1054      +539     
Impacted Files Coverage Δ
MatrixSDK/Data/MXRoomSummary.m 55.26% <100.00%> (+38.59%) ⬆️
...o/Algorithms/RoomEvent/MXRoomEventDecryption.swift 52.55% <0.00%> (-0.50%) ⬇️
MatrixSDK/Utils/Media/MXMediaManager.m 1.88% <0.00%> (+0.47%) ⬆️
MatrixSDK/Contrib/Swift/MXRestClient.swift 2.22% <0.00%> (+0.74%) ⬆️
...gations/LocationSharing/MXBeaconAggregations.swift 4.44% <0.00%> (+1.26%) ⬆️
MatrixSDKTests/MXBackgroundSyncServiceTests.swift 1.84% <0.00%> (+1.84%) ⬆️
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 23.12% <0.00%> (+1.87%) ⬆️
MatrixSDK/Contrib/Swift/MXSession.swift 14.38% <0.00%> (+2.05%) ⬆️
MatrixSDK/Crypto/Recovery/MXRecoveryService.m 2.33% <0.00%> (+2.33%) ⬆️
...ventsEnumerator/MXEventsByTypesEnumeratorOnArray.m 91.89% <0.00%> (+2.70%) ⬆️
... and 186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 395bb44 into develop Feb 22, 2023
@alfogrillo alfogrillo deleted the alfogrillo/fix_threads_unread_filter branch February 22, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads: When read, doesn't leave Unreads filter view
2 participants