Direct room with a third party #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 37.38% // Head: 17.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1727 +/- ##
============================================
- Coverage 37.38% 17.63% -19.76%
============================================
Files 612 612
Lines 96171 96185 +14
Branches 41586 40387 -1199
============================================
- Hits 35952 16960 -18992
- Misses 59164 78709 +19545
+ Partials 1055 516 -539
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes part of element-ios #6612
When creating a direct chat with a 3rd party, use their email as the direct room id.
When updating the room summary, use the third party display name, if available, rather than empty room.