Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when roomSummary is nil #1731

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 3, 2023

This PR fixes the following crash: element-hq/element-ios#7403

@Velin92 Velin92 requested a review from Anderas March 3, 2023 10:57
@Velin92 Velin92 requested review from a team and Anderas and removed request for Anderas and a team March 3, 2023 11:20
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 20.37% and project coverage change: -0.09 ⚠️

Comparison is base (f52a4d2) 37.53% compared to head (8c05fab) 37.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1731      +/-   ##
===========================================
- Coverage    37.53%   37.44%   -0.09%     
===========================================
  Files          612      612              
  Lines        96235    96266      +31     
  Branches     41603    41613      +10     
===========================================
- Hits         36119    36046      -73     
- Misses       59041    59163     +122     
+ Partials      1075     1057      -18     
Impacted Files Coverage Δ
.../Background/Store/MXSyncResponseStoreManager.swift 0.00% <0.00%> (ø)
MatrixSDK/Data/MXRoom.m 37.86% <0.00%> (ø)
...List/Common/MXBreadcrumbsRoomListDataFetcher.swift 0.00% <0.00%> (ø)
.../Data/RoomList/Common/MXRoomListDataSortable.swift 79.06% <0.00%> (ø)
...mList/CoreData/MXCoreDataRoomListDataFetcher.swift 59.71% <0.00%> (ø)
MatrixSDK/MXSession.m 39.72% <ø> (-0.15%) ⬇️
MatrixSDK/Space/MXSpaceService.swift 42.31% <0.00%> (ø)
MatrixSDK/VoIP/MXCall.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXBackgroundSyncServiceTests.swift 1.84% <0.00%> (ø)
MatrixSDKTests/MXLazyLoadingTests.m 0.00% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the inline comments

MatrixSDK/MXSession.h Show resolved Hide resolved
@Velin92 Velin92 requested a review from stefanceriu March 6, 2023 10:11
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@Velin92 Velin92 merged commit 3ab1b90 into develop Mar 6, 2023
@Velin92 Velin92 deleted the mauroromito/fix_crash_when_roomSummary_is_nil branch March 6, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes with SIGABRT when typing any letter in search
2 participants