Login: Handle well-known data in the login response #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API response data model (new MXLoginResponse class)
…s property is never nil
MatrixSDK/MXRestClient.m
Outdated
| @@ -575,7 +553,7 @@ - (MXHTTPOperation *)loginWithLoginType:(NSString *)loginType username:(NSString | |||
|
|
|||
| - (NSString*)loginFallback; | |||
| { | |||
| return [[NSURL URLWithString:@"/_matrix/static/client/login/" relativeToURL:[NSURL URLWithString:homeserver]] absoluteString]; | |||
| return [[NSURL URLWithString:@"/_matrix/static/client/login/" relativeToURL:[NSURL URLWithString:self.credentials.homeServer]] absoluteString]; | |||
There was a problem hiding this comment.
Check self.credentials.homeServer nullability as NSURL URLWithString: wait a nonnull string.
| @@ -2780,7 +2758,7 @@ - (MXHTTPOperation*)add3PID:(NSString*)sid | |||
| success:(void (^)(void))success | |||
| failure:(void (^)(NSError *error))failure | |||
| { | |||
| NSURL *identityServerURL = [NSURL URLWithString:_identityServer]; | |||
| NSURL *identityServerURL = [NSURL URLWithString:self.credentials.identityServer]; | |||
There was a problem hiding this comment.
Same remark as above check self.credentials.identityServer nullability.
SBiOSoftWhare
approved these changes
Feb 28, 2019
matrix.org returns https://matrix.org/
SBiOSoftWhare
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MXCredentials is a new separate data model that allows to manage well-known data in one place.
The PR has these 2 main changes
Other changes is about factorisation to use a central MXCredentials object.