MXBackgroundSyncService: Clear the bg sync crypto db if needed #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
element-hq/element-ios#3956 We need to reset this db from the NSE process. The init operation seems to be the best place to check this.
Every app should have a applicationGroupIdentifier in prod now
so that we do need to open the DB to clear it
ismailgulek
approved these changes
Jan 20, 2021
MatrixSDK/Crypto/Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m
Outdated
Show resolved
Hide resolved
…ore.m Co-authored-by: ismailgulek <[email protected]>
…once per push We dit it twice in a row for each new push. As launchBackgroundSync can be called several times to fetch keys. This is also dangerous to reset caches in the middle of the process of a push. [RLM deleteFilesForConfiguration:] does not like to be called twice in a row
…impl in case of error The old implementation requires a valid db but if the db is already opened. We can expect it to be valid.
ismailgulek
reviewed
Jan 22, 2021
ismailgulek
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we will be able to even clear corrupted db. This should fix element-hq/element-ios#3956.
It does not prevent the corruption (even Realm does not know how it can happen) but the app and the NSE will auto fix themselves. The user will just need to open the app.
Opening the app will clear the background sync cache. On the next push, the bg sync service will detect that the bg sync cache is empty, it will then clear the realm db. Any corrupted db issue is solved.
Some notifications will not be able to decrypt but messages will be readable within the app.
This required some changes in
MXRealmCryptoStoreto delete the db without opening it.