Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send id_access_token to HS for use in proxied IS requests #1022

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Aug 22, 2019

This passes along the id_access_token to the HS, which it will need when
speaking v2 IS APIs to the IS.

Unfortunately, some HSes seem to explode when given this new parameter, so we
only pass it along for the moment if an unstable feature m.id_access_token is
also set.

Part of element-hq/element-web#10525
Used by matrix-org/matrix-react-sdk#3337
Defined in MSC2140

This passes along the `id_access_token` to the HS, which it will need when
speaking v2 IS APIs to the IS.

Unfortunately, some HSes seem to explode when given this new parameter, so we
only pass it along for the moment if an unstable feature `m.id_access_token` is
also set.

Part of element-hq/element-web#10525
Defined in MSC2140
@jryans jryans requested a review from a team August 22, 2019 13:48
@turt2live turt2live requested review from turt2live and removed request for a team August 22, 2019 14:44
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, just some comments about the design pattern

src/client.js Outdated Show resolved Hide resolved
@jryans jryans requested a review from turt2live August 23, 2019 10:18
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for suffering my design pattern review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants