Sign key backup with cross-signing key on upgrade #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a signature from the cross-signing master key to the key backup when upgrading the key backup into cross-signing. For element-hq/element-web#11747
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 9, 2020
If we trust the key backup at upgrade time then we can sign it so key backup will work automatically when cross-signing is trusted. If we don't sign it at this point we'll end up with cross-signing and key backup set up but key backup untrusted by the cross-signing key which is a bit of a broken situation. With matrix-org/matrix-js-sdk#1144 fixes element-hq/element-web#11747
jryans
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a signature from the cross-signing master key to the key
backup when upgrading the key backup into cross-signing.
For element-hq/element-web#11747