Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TimestampToEventResponse to use in matrix-react-sdk tests #3223

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Mar 21, 2023

Export TimestampToEventResponse to use in matrix-react-sdk tests

Part of matrix-org/matrix-react-sdk#10405

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

src/client.ts Outdated
@@ -837,7 +837,7 @@ interface IRoomHierarchy {
next_batch?: string;
}

interface ITimestampToEventResponse {
export interface ITimestampToEventResponse {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our new code style interfaces should not start with an I.
Can you rename it before merging this PR?

@MadLittleMods
Copy link
Contributor Author

MadLittleMods commented Mar 21, 2023

  1. Interface names should not be marked with an uppercase I.

-- code_style.md#typescript--javascript-typescript-javascript

Updated 👍

@MadLittleMods MadLittleMods changed the title Export ITimestampToEventResponse to use in matrix-react-sdk tests Export TimestampToEventResponse to use in matrix-react-sdk tests Mar 21, 2023
@MadLittleMods MadLittleMods added this pull request to the merge queue Mar 21, 2023
@MadLittleMods MadLittleMods removed this pull request from the merge queue due to a manual request Mar 21, 2023
@MadLittleMods MadLittleMods added this pull request to the merge queue Mar 21, 2023
@MadLittleMods
Copy link
Contributor Author

Thanks for the review and approval @weeman1337 🐈

Is it possible to squash anymore and adjust the commit message?

I've added it to the merge queue 🤷

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2023
@MadLittleMods MadLittleMods added this pull request to the merge queue Mar 21, 2023
@MadLittleMods MadLittleMods merged commit f12cee9 into develop Mar 21, 2023
@MadLittleMods MadLittleMods deleted the madlittlemods/export-ITimestampToEventResponse-to-use-in-tests branch March 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants