Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix accidentally inverted condition for room ordering #10178

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Fix accidentally inverted condition for room ordering #10178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486b2a9
Remove unnecessary, accidentally inverted condition for room ordering
justjanne Feb 16, 2023
c853192
Merge branch 'develop' into justjanne/fix/24527-room-ordering
justjanne Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/stores/room-list/algorithms/list-ordering/ImportanceAlgorithm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class ImportanceAlgorithm extends OrderingAlgorithm {
// Every other sorting type affects the categories, not the whole tag.
const categorized = this.categorizeRooms(rooms);
for (const category of Object.keys(categorized)) {
if (!isNaN(Number(category))) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Just a general rooms should be sorted as expected test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line added before? Did it ever make sense?

Why can we remove it now?

Let's add this context to the PR description

const notificationColor = category as unknown as NotificationColor;
const roomsToOrder = categorized[notificationColor];
categorized[notificationColor] = sortRoomsWithAlgorithm(
Expand Down