Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update tests to ensure file size unit has been fixed #10568

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Update tests to ensure file size unit has been fixed #10568

merged 4 commits into from
Apr 12, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 11, 2023

This PR is a follow-up to #10561 in order to ensure that file size unit used on a file tile or audio player is kibibytes (1024 bytes), not kilobytes (1000 bytes).

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 11, 2023
@luixxiul luixxiul marked this pull request as ready for review April 11, 2023 18:12
@luixxiul luixxiul requested a review from a team as a code owner April 11, 2023 18:12
cypress/e2e/timeline/timeline.spec.ts Outdated Show resolved Hide resolved
uploadFile("cypress/fixtures/matrix-org-client-versions.json");

cy.get(".mx_FilePanel .mx_EventTile").within(() => {
// Assert that the file size is displayed in kilobyte, not kibibyte (kB)
Copy link
Member

@richvdh richvdh Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Assert that the file size is displayed in kilobyte, not kibibyte (kB)
// Assert that the file size is displayed in kibibytes (1024 bytes), not kilobytes (1000 bytes)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly the other references to kilobytes in this PR should be changed to kibibytes too, though it's not too important because "kilobyte" can mean either 1024 bytes or 1000 bytes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood. I have not known kilobyte could mean both.. 😲

Signed-off-by: Suguru Hirahara <[email protected]>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh added this pull request to the merge queue Apr 12, 2023
@luixxiul
Copy link
Contributor Author

@richvdh Thanks for the review!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2023
@richvdh richvdh added this pull request to the merge queue Apr 12, 2023
Merged via the queue into matrix-org:develop with commit bef6eca Apr 12, 2023
@luixxiul luixxiul deleted the test-file-size branch April 12, 2023 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants