This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Revert "Move reaction message previews out of labs" #10860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4dd2145.
andybalaam
approved these changes
May 11, 2023
t3chguy
added
the
T-Task
@andybalaam the delabsing also included bahavioural changes, so not without having to rewrite most of it. https:/matrix-org/matrix-react-sdk/pull/10860/files#diff-0a1a085be24a592caf71b8186a7ff0e625ff44746354c559e69584b50a1402e0 shows the behavioural changes to include message content etc |
weeman1337
suggested changes
May 11, 2023
weeman1337
approved these changes
May 11, 2023
daniellekirkwood
suggested changes
May 11, 2023
There was a problem hiding this comment.
we're still discussing the approach we want to take with reactions in previews. best to hold off on this until the decision has been made by @VolkerJunginger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10601
This change is marked as an internal change (Task), so will not be included in the changelog.