This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: 1st go at resizing room sublists #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way, we'll be able to add adjacent resize handles and scroll wrappers
works with the flex-grow we set initially for the sub lists
without this, in small sizes, it would make the header shrink.
dbkr
approved these changes
Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st go at making the sub lists scrollable and allowing to resize them.
Need to set
flex-basisandmax-heighton the sub lists individually as gemini-scrollable areas haveposition: absolute, and thus can't be sized by their content.Upon resizing the sizes are not persisted yet, first want to see in what unit they should be persisted (px, %, ..)
Relies on #2224 being merged first.
Part of element-hq/element-web#7162 / element-hq/element-web#7161