Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support changing your integration manager in the UI #3308

Merged
merged 11 commits into from
Aug 14, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 12, 2019

Fixes element-hq/element-web#10161 (this is the last of the PRs in the series for this issue)

Known missing from this PR:

Based upon:

Changeset: 03d735f. changed

Gif:
integration-manager-change mp4

@dbkr dbkr requested review from dbkr and removed request for a team August 14, 2019 08:42
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll leave you to figure out the field widths etc. I think the reason it fits for you here but didn't for me is that my window is narrower and so there isn't enough space to the right of the settings dialog so it goes off the screen.

@turt2live
Copy link
Member Author

I'll adopt the use of the mixin and leave fixing it for element-hq/element-web#10554 (which I also plan to take on, just not here)

This avoids us having to throw the entirety of MSC1957 into the queue, particularly when we're only using a third of the MSC.
@turt2live
Copy link
Member Author

@dbkr I've switched this over to using vector-namespaced widget types to avoid having to put MSC1957 through the queue (we only use about a third of it). Please take a quick look.

@turt2live turt2live requested a review from dbkr August 14, 2019 14:58
@dbkr
Copy link
Member

dbkr commented Aug 14, 2019

Bleugh, then people will end up with this im.vector.integration_manager in the wild and we'll have to worry about the transition. I think that will ultimately make life even more complex. I'd rather not have it kicking around if at all possible - even if we have to disable this until the MSC is through.

@turt2live
Copy link
Member Author

I'll just get the MSC through the process and start writing up the implementation we're missing.

@turt2live
Copy link
Member Author

@dbkr done - now just not using vector-namespaced things

@dbkr
Copy link
Member

dbkr commented Aug 14, 2019

Thanks - I've made the MSC slightly closer!

@turt2live turt2live merged commit f69235b into develop Aug 14, 2019
@turt2live turt2live deleted the travis/integs/account_set branch August 14, 2019 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Integration Manager preferences in account data and allow user to change them somewhere sensible
2 participants