Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Slash Command improvements around sending messages with leading slash #3893

Merged
merged 9 commits into from
Jan 22, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 21, 2020

Fixes element-hq/element-web#11580
Fixes element-hq/element-web#4630

Allows // to send messages starting with / (/// for // and so forth)
Allows changing a command to a non-command for in the case of typing /me but then editing it to be */me*, previously this would just blank out the composer without any say why.
When entering an unknown command, e.g /test, previously a modal came up telling you that the command is unknown and your composer got wiped out, now your composer is retained unless you select the new option on the modal to Send as message

The // case comes with Tests :D

image

@t3chguy t3chguy marked this pull request as ready for review January 21, 2020 18:00
@t3chguy t3chguy requested a review from a team January 21, 2020 18:03
@foldleft foldleft self-requested a review January 22, 2020 14:25
@t3chguy t3chguy merged commit 97edb82 into develop Jan 22, 2020
@t3chguy t3chguy deleted the t3chguy/double_slash branch May 25, 2020 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants