This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Wait for verification request on login #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically just changes to the designed screen to wait for an incoming verification request in order to verify the device & cross-sign it. Fixes element-hq/element-web#11215 Fixes element-hq/element-web#11217
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just changes to the designed screen to wait for an incoming
verification request in order to verify the device & cross-sign it.
Fixes element-hq/element-web#11215
Fixes element-hq/element-web#11217
NB. to verify with riot x requires element-hq/element-android#1134 otherwise riot x sits there & does nothing (as will any other client that doesn't implement the equivalent).
Video of verification with another riot-web (gzipped so github will let me upload it...):
Screen Recording 2020-03-16 at 17.46.48.mov.gz