This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Minor improvements to filtering performance #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards the room list not having to concern itself with the search parameters.
This prevents the entire left panel from having to re-mount whenever the search query changes.
It's a bit more complicated this way, but helps reduce some of the latency involved in remounting the entire room list.
It slows things down a bit, and in practice is more unlikely to be a problem than a savior.
This is just maintenance noticed while debugging.
This could in theory cause double rendering of the room list under some conditions.
This reduces the update cost of rooms changing, and fixes a bug where when a sublist became filtered it would change the notification count of the sublist. This does change the expected usage of the state store to ensuring that only one place updates the rooms on the list states, which is currently the room list store. Ideally the state store could listen to the room list store to update itself, however due to a complicated require() loop it is not possible.
t3chguy
approved these changes
Jul 28, 2020
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#14750
These changes are likely best reviewed commit-by-commit.
Collectively these do not improve the situation too well: on a test account they have reduced times for 2.0 seconds to 1.4 seconds per key. We do have some throttle logic in place in these changes, however in this account's case it does not help as the task overall takes longer than the keypress handling.
There is not much more we can do to improve this situation. We can't lazily load room tiles, can't render them elsewhere to put them into the DOM, and can't do much about how tooltips work. If we could somehow do one of these three, it could increase performance by 1-5x. For now though, this is likely going to have to be fine.