This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix size of portrait images with the SIZE_NORMAL setting. #7188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, portrait images are drawn with the same width than Landscape images.
This was the requested behavior from design..
This PR #7171 fixed a bug for really high images but also made portrait images not behave as desired anymore.
(see the comments in the changed files for the logic used to determine image sizes)
Left old, right new (for the large setting nothing changes)
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://619f6fe0dafa3d153dcf4a2f--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.