Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve top of pagination scroll panel gap #8030

Closed
wants to merge 3 commits into from
Closed

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 11, 2022

Fixes element-hq/element-web#20594
Fixes element-hq/element-web#20896


Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://pr8030--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Mar 11, 2022
@t3chguy t3chguy marked this pull request as ready for review March 11, 2022 07:57
@t3chguy t3chguy requested a review from a team as a code owner March 11, 2022 07:57
@t3chguy t3chguy marked this pull request as draft March 11, 2022 07:58
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #8030 (316c91c) into develop (9082e07) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop    #8030      +/-   ##
===========================================
- Coverage    26.66%   26.65%   -0.02%     
===========================================
  Files          862      862              
  Lines        51954    51940      -14     
  Branches     13159    13156       -3     
===========================================
- Hits         13854    13843      -11     
+ Misses       38100    38097       -3     
Impacted Files Coverage Δ
src/components/structures/ScrollPanel.tsx 31.97% <80.00%> (-1.83%) ⬇️

@germain-gg
Copy link
Contributor

This extra gap was there on purpose, because of https:/matrix-org/matrix-react-sdk/blob/develop/docs/scrolling.md#bacat-bottom-aligned-clipped-at-top-scrolling which is why I had not touched it yet.

Not entirely sure whether this is not extraenous or not

@t3chguy
Copy link
Member Author

t3chguy commented Mar 11, 2022

This extra gap was there on purpose

I know that, this draft is a playground to try a different approach as the hiding of the scrollbar is never going to solve the problem of the scrollbar sometimes being hidden whilst things are off-screen already.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far - the codeowners review can't be removed, and all the stats think this is in a queue, so giving it a review now. Happy to re-review if/when ready.

@t3chguy t3chguy closed this May 3, 2022
@SimonBrandner SimonBrandner deleted the t3chguy/fix/20896 branch May 3, 2022 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra space (gap) above messages Thread panel doesn't handle window resizing
3 participants