Redis crypto store #1256
Redis crypto store #1256
Conversation
andybalaam
force-pushed
the
redis-store3
branch
from
679cb67
to
7a9273f
Compare
Codecov ReportBase: 74.22% // Head: 74.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 74.22% 74.43% +0.21%
==========================================
Files 114 119 +5
Lines 13007 13581 +574
==========================================
+ Hits 9654 10109 +455
- Misses 3353 3472 +119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think this is ready for review when people have time. |
| let mut connection = self.client.get_async_connection().await.unwrap(); | ||
| let redis_key = | ||
| format!("{}secret_requests_by_info|{}", self.key_prefix, key_info.redis_key()); | ||
| let id: Option<String> = connection.get(&redis_key).await.unwrap(); |
| let mut connection = self.client.get_async_connection().await.unwrap(); | ||
| let redis_key = format!("{}unsent_secret_requests", self.key_prefix); | ||
| let req_map: HashMap<String, Vec<u8>> = connection.hgetall(&redis_key).await.unwrap(); | ||
| Ok(req_map.values().map(|req| self.deserialize_value(req).unwrap()).collect()) |
There was a problem hiding this comment.
Three unwrap()s here as well.
| type Conn: RedisConnectionShim; | ||
|
|
||
| async fn get_async_connection(&self) -> RedisResultShim<Self::Conn>; | ||
| fn get_connection_info(&self) -> &redis::ConnectionInfo; | ||
| fn create_pipe(&self) -> Box<dyn RedisPipelineShim<Conn = Self::Conn>>; |
There was a problem hiding this comment.
Like type Conn, the pipeline type can probably be an associated type instead of being boxed and dynamically dispatched, right?
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Co-authored-by: Jonas Platte <[email protected]>
Over Matrix we agreed that this might turn up in a different repo, or in a "labs" section of this repo. Both are fine by me - I didn't get anyone's approval before working on this and appreciate it could be hard work to maintain. Thanks for the review Jonas - I will work on the non-suggestion changes when I get a chance. |
|
I'm going to close this since it has a number of maintenance downsides to have this crate in the same repo as the SDK itself:
That said, I am happy to be pinged about Ruma- and Rust SDK-related maintenance tasks in matrix-sdk-redis once it has its own repo. |
|
New repo is https://codeberg.org/andybalaam/matrix-sdk-redis |
Create a Redis crypto store to allow deploying e.g. in a Kubernetes environment with no disk.
Signed-off-by: Andy Balaam <[email protected]>