fix(indexeddb): correctly encode Olm session keys #1429
Conversation
When we store an Olm session in the database, we encode the sender key and session ID using the store cipher. That means that we also need to encode them when we look them up, otherwise we won't find them.
Codecov ReportBase: 73.58% // Head: 73.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
=======================================
Coverage 73.58% 73.58%
=======================================
Files 116 116
Lines 12996 12996
=======================================
Hits 9563 9563
Misses 3433 3433 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I was wondering why our CI didn't catch this and wondered if we indeed don't have a test for this. Seems that wasm-pack is in a sad state: matrix-rust-sdk/crates/matrix-sdk-indexeddb/src/crypto_store.rs Lines 1094 to 1095 in e2cd873 Which points towards #661. The comment and issue are as it seems talking about happier times, |
Upgrade matrix-sdk-crypto-js, to pick up matrix-org/matrix-rust-sdk#1429
#3126) Upgrade matrix-sdk-crypto-js, to pick up matrix-org/matrix-rust-sdk#1429
When we store an Olm session in the database, we encode the sender key and
session ID using the store cipher. That means that we also need to encode them
when we look them up, otherwise we won't find them.