Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API to request missing secrets #2641

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

BillCarsonFr
Copy link
Member

Adds a new crypto API to request missing secrets + the ffi bindings.

This API will look at the missing private secrets (usk, ssk, msk, megolm.backup), and if they are not present on the current session it will make requests for them.
The request are properly saved in "outgoing_request store" to ensure proper handling, it's also checking if there are no existing requests in fligh.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 28, 2023 14:02
@BillCarsonFr BillCarsonFr requested review from bnjbvr and removed request for a team September 28, 2023 14:02
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4478826) 77.94% compared to head (5080c54) 78.09%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
+ Coverage   77.94%   78.09%   +0.15%     
==========================================
  Files         190      190              
  Lines       19663    19680      +17     
==========================================
+ Hits        15327    15370      +43     
+ Misses       4336     4310      -26     
Files Coverage Δ
crates/matrix-sdk-crypto/src/machine.rs 83.48% <100.00%> (+0.53%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, not sure when/how we'll utilize this in the main crate but seems to be generally useful to have this ability.

@poljar poljar merged commit ab2f18d into main Sep 29, 2023
36 checks passed
@poljar poljar deleted the valere/crypto_secret_api branch September 29, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants