Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove query_auth from the specification per MSC2451. #2470

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Remove query_auth from the specification per MSC2451. #2470

merged 3 commits into from
Mar 24, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 24, 2020

This is per MSC #2451 (rendered version).

Synapse v1.12.0 removed this endpoint in matrix-org/synapse#7026.

turt2live
turt2live requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry and then you're all set :)

Thanks!

@clokep clokep requested a review from turt2live March 24, 2020 17:17
@clokep
Copy link
Member Author

clokep commented Mar 24, 2020

Oops! Added!

turt2live
turt2live approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we don't have removal as a changelog type, but this sort of change applies to no other changelog type. I'll merge this and get a removal type added.

@turt2live turt2live merged commit b6d97c5 into master Mar 24, 2020
@clokep clokep deleted the clokep/remove-query-auth branch March 24, 2020 18:49
@clokep
Copy link
Member Author

clokep commented Mar 24, 2020

so we don't have removal as a changelog type, but this sort of change applies to no other changelog type. I'll merge this and get a removal type added.

Thanks, was just going off of what Synapse has.

@sl4m sl4m mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @turt2live