Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Room ID requirements #1826

Closed
HarHarLinks opened this issue May 23, 2024 · 5 comments · Fixed by #1850
Closed

Clarify Room ID requirements #1826

HarHarLinks opened this issue May 23, 2024 · 5 comments · Fixed by #1850
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit help wanted Interested in contributing to the spec? These would be great additions!

Comments

@HarHarLinks
Copy link
Contributor

Link to problem area:
https://spec.matrix.org/latest/appendices/#room-ids

Issue

@HarHarLinks HarHarLinks added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label May 23, 2024
@richvdh
Copy link
Member

richvdh commented May 23, 2024

I think this is a duplicate of #1001?

@richvdh
Copy link
Member

richvdh commented May 23, 2024

Why are room IDs used in state keys?

@deepbluev7
Copy link
Contributor

Why are room IDs used in state keys?

https://spec.matrix.org/v1.10/client-server-api/#mspacechild-relationship

@HarHarLinks
Copy link
Contributor Author

for some reason, size limits appear in this place https://spec.matrix.org/v1.10/client-server-api/#size-limits

this might answer my second question and is not referenced from the appendix section

@richvdh
Copy link
Member

richvdh commented May 24, 2024

Oh, that section seems pretty clear about the requirements here.

Seems like this should be defined in the appendix, and then referenced from the "size limits" section.

PRs to update this would be very welcome.

@richvdh richvdh added the help wanted Interested in contributing to the spec? These would be great additions! label May 24, 2024
Johennes added a commit to Johennes/matrix-spec that referenced this issue Jun 7, 2024
…larify that the length is to be measured in bytes

Fixes: matrix-org#1826
Signed-off-by: Johannes Marbach <[email protected]>
Johennes added a commit to Johennes/matrix-spec that referenced this issue Jun 7, 2024
…larify that the length is to be measured in bytes

Fixes: matrix-org#1826
Relates to: matrix-org#1001
Signed-off-by: Johannes Marbach <[email protected]>
richvdh pushed a commit that referenced this issue Jun 12, 2024
…larify that the length is to be measured in bytes (#1850)

Fixes: #1826
Relates to: #1001
Signed-off-by: Johannes Marbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit help wanted Interested in contributing to the spec? These would be great additions!
Projects
None yet
3 participants