-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web push improvements #186
Comments
This was referenced Apr 7, 2021
erikjohnston
pushed a commit
that referenced
this issue
Apr 8, 2021
Part of #186: - Only reject push key on 404 or 410 response codes - Trim message body so we don't exceed 4096 characters - Log when returned TTL header is lower than request - Support events_only flag on push data, to avoid bogus notifications in browser.
Looks like these tasks are done, can we close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TTL
header is lower than requestevents_only
flag on push data, as web push clients can't clear all notifications in response to a push message; the standard says that a notification should always be visible after processing a push event when the page is in the background, if not the browser shows a generic one for you.So in the case where you tap notification, close the page again, and the
unread=0
notification arrives because the room is marked as read somewhere, you'll receive theunread=0
notification and you don't have the previous notification visible any more, you'll have no choice to either show a generic notification or let the browser show its generic notification in response to the event, where you really don't want to show anything. For this case, you can setevents_only: true
in the push data and these kind of push messages won't be forwarded, so you don't have the problem.Urgency
header based onprio
field in notification:Topic
header to a hash of the room id. This should be enabled with a flag in the push data.The text was updated successfully, but these errors were encountered: