Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Reenable opentracing in _handle_new_device_update_async #12559

Open
DMRobertson opened this issue Apr 26, 2022 · 0 comments
Open

Reenable opentracing in _handle_new_device_update_async #12559

DMRobertson opened this issue Apr 26, 2022 · 0 comments
Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Logging Synapse's logs (structured or otherwise). Not metrics. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@DMRobertson
Copy link
Contributor

In #12552 we encountered pain because of a log_kv call that was not correctly associated with an opentracing span.

#12554 avoided the pain by commenting out the call to log_kv.

It's still useful to have this data available for debugging. We should fix this so that we are able to log_kv once more. #12552 (comment) describes two possible ways to do so. The error mentioned in its last paragraph has been fixed by #12555.

@DMRobertson DMRobertson added A-Logging Synapse's logs (structured or otherwise). Not metrics. A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Logging Synapse's logs (structured or otherwise). Not metrics. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

1 participant