Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against latest deps is failing #12574

Closed
github-actions bot opened this issue Apr 28, 2022 · 2 comments · Fixed by #12576
Closed

CI run against latest deps is failing #12574

github-actions bot opened this issue Apr 28, 2022 · 2 comments · Fixed by #12576
Assignees
@DMRobertson

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022 •
edited
Loading

See https:/matrix-org/synapse/actions/runs/2243864760
@DMRobertson
Copy link
Contributor 

Run poetry run mypy
  poetry run mypy
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.4/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.4/x64/lib
synapse/logging/opentracing.py:234: error: Unused "type: ignore" comment
tests/replication/_base.py:39: error: Unused "type: ignore" comment
tests/logging/test_opentracing.py:37: error: Unused "type: ignore" comment
tests/logging/test_opentracing.py:46: error: Unused "type: ignore" comment
Found 4 errors in 3 files (checked 710 source files)
Error: Process completed with exit code 1.

Casualty of #12531. I think we ought to disable the unused type ignore check in this job, and probably in the twisted trunk job too.

@DMRobertson DMRobertson self-assigned this Apr 28, 2022
DMRobertson pushed a commit that referenced this issue Apr 28, 2022
Allow unused ignores in "bleeding edge" CI
4fadcad 
Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs.

Follow up from #12531.
Resolves #12574.
@DMRobertson DMRobertson mentioned this issue Apr 28, 2022
Merged
@DMRobertson
Copy link
Contributor

Reopening because I accidentally commited to develop directly.

@DMRobertson DMRobertson reopened this Apr 28, 2022
DMRobertson pushed a commit that referenced this issue Apr 29, 2022
Allow unused ignores in "bleeding edge" CI (#12576)
57fac2a 
* Allow unused ignores in "bleeding edge" CI

Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs.

Follow up from #12531.
Resolves #12574.

* Use `--extras all` in latest deps mypy CI

Twisted trunk job already does this.

Missed in #12531.

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow unused ignores in "bleeding edge" CI matrix-org/synapse
1 participant
@DMRobertson